[Rename flyout] Fixed cropping issue on small screens#77466
Merged
CyrusNajmabadi merged 2 commits intodotnet:mainfrom Mar 10, 2025
veler:dev/etbaudou/rename-layout-cropping
Merged
[Rename flyout] Fixed cropping issue on small screens#77466CyrusNajmabadi merged 2 commits intodotnet:mainfrom veler:dev/etbaudou/rename-layout-cropping
CyrusNajmabadi merged 2 commits intodotnet:mainfrom
veler:dev/etbaudou/rename-layout-cropping
Conversation
ghost
added
Area-IDE
untriaged
dotnet-policy-service
bot
added
Community
src/EditorFeatures/Core.Wpf/InlineRename/UI/Adornment/RenameFlyout.xaml.cs
Outdated
Show resolved
Hide resolved
sandyarmstrong
approved these changes
Mar 7, 2025
CyrusNajmabadi
approved these changes
Mar 10, 2025
This was referenced Mar 11, 2025
jasonmalinowski
added a commit
that referenced
this pull request
Jul 8, 2025
When Rename is invoked after scrolling up, the adornment is occasionally displayed misplaced out of viewport. See https://developercommunity.visualstudio.com/t/Rename-dialog-opens-up-outside-of-editor/10919621. . This is a regression from #77466, which was a fix for horizontal clipping but also changed vertical positioning to never be negative. Unfortunately, when scrolling up, text view's viewport top and bottom can be negative. The fix is to remove unnecessary Math.Max on top position value.
dibarbet
added a commit
that referenced
this pull request
Jul 9, 2025
When Rename is invoked after scrolling up, the adornment is occasionally displayed misplaced out of viewport. See https://developercommunity.visualstudio.com/t/Rename-dialog-opens-up-outside-of-editor/10919621. This is a regression from #77466, which was a fix for horizontal clipping but also changed vertical positioning to never be negative. Unfortunately, when scrolling up, text view's viewport top and bottom can be negative. The fix is to remove unnecessary Math.Max on top position value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Rename flyout is being cropped on small screens. The issue being that:
Solution
Basically, address all of the above: